Fix libinstpatch and sndfile not being discovered on Windows #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DominusExult
added a commit
to DominusExult/fluidsynth-sans-glib
that referenced
this pull request
Mar 6, 2024
* commit '683270db64302e59d26b9610514af1cfe0a80493': Bump to 2.3.5 Fix libinstpatch and sndfile not being discovered on Windows (FluidSynth#1299) Update FreeBSD CI: Drop 12.4 and add 14.0 Fix some rounding issues due to double promotion (FluidSynth#1286) Bump to 2.3.4 Fix player termination after stopping and restarting (FluidSynth#1273) fix for issue FluidSynth#1268: Pipewire's Jack implementation not found (FluidSynth#1269) Fix issue with CMake Xcode generator (FluidSynth#1266) Refurbish CI (FluidSynth#1267) Fallback to IPv4 when creating socket if IPv6 is not available (FluidSynth#1208) (FluidSynth#1265) Turn off pending notes and issue a warning (FluidSynth#1264) Fix incorrect way of turning CMAKE_INSTALL_LIBDIR absolute (FluidSynth#1261)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libinstpatch and sndfile are using different library filenames on Windows. Previously, the CMake scripts were only looking for their Unix names resulting in the libraries not being found. This PR fixes it, and therefore implicitly restores DLS support for the precompiled Windows binaries.
In addition, we're no longer relying on sndfile's pkgconfig file to report correct private libs to figure out whether it has OGG / Vorbis support. This change restores SF3 support for precompiled Windows binaries.
This latter change revealed two more problems: 1) parsing of the
OPUS_VERSIONwas broken and could led to an index-out-of-range error, and 2) the logic inFindmpg123was missing theIMPORTEDkeyword.Fixes #1298